Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automerge to Dependabot Config #1153

Closed
wants to merge 2 commits into from

Conversation

thedavidprice
Copy link
Contributor

Fixes #1122

@peterp The config for Dependabot is much more limited than I anticipated. Here's what we can do:

  • Automerge patch updates
  • completely ignore core-js and @bable (will not submit PRs)

I'm not sure how to test this other than to merge and see how it works 😬

Re: completely ignoring all core-js and @babel* packages: aren't these two examples we should manually manage? I thought about trying to just ignore them from auto merger using the following, but I wasn't sure if it would work.

      - match:
          dependency_name: "!core-js"
          dependency_name: "!@babel*"

Thoughts/suggestions about proceeding forward with this?

Comment on lines 10 to 12
- match:
dependency_name: "core-js"
dependency_name: "@babel*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it so that these packages are automatically determined via the configuration:

version: packageJSON.devDependencies['@babel/runtime-corejs3'],

We can remove these now :)

Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks @thedavidprice <3

.github/dependabot.yml Outdated Show resolved Hide resolved
@thedavidprice
Copy link
Contributor Author

Well, after all that, turns out this is no longer a thing:
dependabot/dependabot-core#1973 (comment)

Bummer.

@Tobbe Tobbe deleted the dsp-add-dependabot-automerge-settings branch December 25, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot Improvement: Auto-merge patch releases
2 participants