chore(rsc): upgrade to react canary #10194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-rsc/upgarde-to-react-canary
branch
2 times, most recently
from
5baa36b to
09a968d
Compare
jtoar
added a commit
that referenced
this pull request
Mar 15, 2024
…ions (#10229) Upgrading to the canary versions of the react packages in #10194 is confounded by the fact that a Redwood project's web-side package.json requests versions 18.2.0. Our sync commands should be setting the resolutions of those packages as well as the Redwood ones. This PR updates `yarn rwfw project:tarsync` to set resolutions for `react` and `react-dom`.
jtoar
force-pushed
the
ds-rsc/upgarde-to-react-canary
branch
2 times, most recently
from
05982d2 to
6ab737a
Compare
jtoar
force-pushed
the
ds-rsc/upgarde-to-react-canary
branch
2 times, most recently
from
dab5b7f to
431e1e7
Compare
jtoar
force-pushed
the
ds-rsc/upgarde-to-react-canary
branch
from
431e1e7 to
b0966d1
Compare
Tobbe
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to see how CI reacts to upgrading to React canary.
I may have over-upgraded (i.e. some fixtures and maybe the docs don't need to be upgraded), but let's see what happens.This upgrade was complicated by facebook/react#27436 which added a poisoned import to
react-server-dom-webpack/server, meaning that if you tried to import from that entry point without the "react-server" condition, it would throw.In a much-earlier PR, Sebastian mentions there generally being two ways to do things:
See facebook/react#26172.
This PR goes with the former, prebundling
react-server-dom-webpack/serverwith the "react-server" condition so that we can avoid having to specify it at runtime. It's hard to tell if this the better option long-term, but since we're keen on getting rid of the worker right now, this moves us closer in that direction. The alternative solution was to move decoding the reply into the worker where the condition is specified.