[Bug?]: Cannot generate enum types with GraphQL Codegen

[tyteen4a03]

What's not working?

A prisma schema:

enum NameStatus {
    NAME_REQUESTED
    NAME_APPROVED
    NAME_DENIED
    NAME_CHANGING
}

ends up being this in GQL Schema:

  enum NameStatus {
    NAME_REQUESTED
    NAME_APPROVED
    NAME_DENIED
    NAME_CHANGING
  }

All fine thus far. But when you generate the TypeScript type it becomes:

export type NameStatus =
  | 'NAME_APPROVED'
  | 'NAME_CHANGING'
  | 'NAME_DENIED'
  | 'NAME_REQUESTED';

I put in this into codegen.yml at the root:

config:
  enumsAsTypes: true
  noExport: true

(noExport just to test if it's the file that's not getting passed down); only the noExport one got passed down and affected the GraphQL typedefs output. The enumAsTypes option got ignored and I'm stuck with no enums.

How do we reproduce the bug?

No response

What's your environment? (If it applies)

System:
    OS: macOS 12.4
    Shell: 5.9 - /opt/homebrew/bin/zsh
  Binaries:
    Node: 16.14.2 - /private/var/folders/cg/srfblk2d7bq2dw2tqjt94qkh0000gn/T/xfs-2b3a723a/node
    Yarn: 3.2.1 - /private/var/folders/cg/srfblk2d7bq2dw2tqjt94qkh0000gn/T/xfs-2b3a723a/yarn
  Databases:
    SQLite: 3.37.0 - /usr/bin/sqlite3
  Browsers:
    Chrome: 103.0.5060.134
    Firefox: 102.0.1
    Safari: 15.5
  npmPackages:
    @redwoodjs/core: 2.1.0 => 2.1.0

Are you interested in working on this?

• I'm interested in working on this

[jtoar]

hey @tyteen4a03, we just discussed this one and will move on it soon—thanks for reporting!

[muhajirdev]

enumAsTypes seems to be hardcoded here

redwood/packages/internal/src/generate/graphqlCodeGen.ts

Line 216 in 06cfca3

{ typescript: { enumsAsTypes: true } },

[dthyresson]

Note that the expected result for codegen for the enum when enumsAsTypes is false is:

export enum NameStatus {
  NAME_APPROVED = 'NAME_APPROVED',
  NAME_CHANGING = 'NAME_CHANGING',
  NAME_DENIED = 'NAME_DENIED',
  NAME_REQUESTED = 'NAME_REQUESTED'
}

when true:

export type NameStatus =
  | 'NAME_APPROVED'
  | 'NAME_CHANGING'
  | 'NAME_DENIED'
  | 'NAME_REQUESTED';

Which I can generate by changing

function getCodegenOptions(
  documents: CodegenTypes.DocumentFile[],
  config: CodegenTypes.PluginConfig,
  extraPlugins: CombinedPluginConfig[]
) {
  const plugins = [
    { typescript: { enumsAsTypes: true } }, // <----- here set to false
    ...extraPlugins.map((plugin) => ({ [plugin.name]: plugin.options })),
  ]

So, while I can set the config for settings like:

config:
  namingConvention:
    enumValues: change-case-all#upperCase
    typeNames: change-case-all#lowerCase

which change the case, the enumsAsTypes override doesn't appear to take effect.