French translation for footer #32 #36
Conversation
|
Deploy request for learn-redwood rejected. Rejected with commit 872c934 https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy |
|
I took a peek at your changes and noticed the footer color in light mode is different in your staging site than the production version of site. I am assuming that was an intentional side effect. The top screenshot is what I see in light mode for the footer in the staging server (https://deploy-preview-36--learn-redwood.netlify.app/docs/tutorial/prerequisites/): Whereas what I see in light mode for the footer for the production site (https://learn-redwood.netlify.app/docs/tutorial/welcome-to-redwood) is: |
|
@M0nica, can you check once more? If it's still showing the same issue, can you give me some idea to solve it? I haven't change any format files for the project. I just added the JSON files needed for the translations. Also, when I ran it in the localhost it is working fine. |
Actually, I found out (based on the convo here: #38 (comment)) that the footer color changes are related to a pre-existing strange styling issue that are currently happening in the repo with certain environments 🤔 I see the same footer styling issue on another staging site as well https://deploy-preview-33--learn-redwood.netlify.app/docs/tutorial/welcome-to-redwood. |
|
@M0nica, thanks for the information. So, should I create a new pull request once the issue is fixed? |
I don’t think that waiting for the issue to be resolved is necessary in this case. |
There was a problem hiding this comment.
Like @M0nica mentioned, don't worry about the css problem - that is a separate issue to tackle :)
This works fantastically! Thanks for pioneering this.
Let's keep "Discourse" in French (just like we do Twitter, Discord etc))
| "description": "The label of footer link with label=Discord linking to https://discord.com/invite/redwoodjs" | ||
| }, | ||
| "link.item.label.Discourse": { | ||
| "message": "Discours", |
There was a problem hiding this comment.
Let's keep the translation as "Discourse" since it is a proper noun
| "message": "Discours", | |
| "message": "Discourse", |
|
@clairefro, do you want me to translate |
Great question - I also went back and forth on this since it is the "site title". But now I am thinking YES, as it is more welcoming to those who land on the site. So go ahead! |
|
I made the changes. |
|
something funky seems to be going on with the Netlify checks - I'll look into it so we can merge this |
|
Thank you, @clairefro and @M0nica. I got to learn something new. :) |
I did the french translation for the footer. Can you review it? If there are any queries, free free to mention them.