Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implication that state/props are inherent arguments. #68

Closed
wants to merge 1 commit into from

Conversation

bryanhelmig
Copy link

It feels very React-specific and unnecessary to label those arguments, so why not drop it?

@codecov-io
Copy link

Current coverage is 100.00%

Merging #68 into master will not affect coverage as of 0a53e98

@@            master     #68   diff @@
======================================
  Files            1       1       
  Stmts           41      41       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             41      41       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 0a53e98

Powered by Codecov. Updated on successful CI builds.

@ellbee
Copy link
Collaborator

ellbee commented Dec 21, 2015

Thanks for the PR but we do actually need to label the arguments. See here : https://github.com/rackt/reselect/pull/40/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants