Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated content in "Do I have to put all my state into Redux?" #4434

Merged
merged 3 commits into from
Nov 13, 2022

Conversation

jshoung
Copy link
Contributor

@jshoung jshoung commented Nov 13, 2022


name: 📖 Updated Documentation Content
about: Remove outdated content in "Do I have to put all my state into Redux?"

Checklist

What docs page is being added or updated?

  • Section: Do I have to put all my state into Redux? Should I ever use React's setState()?
  • Page: Redux FAQ: Organizing State

For Updating Existing Content

What updates should be made to the page?

  • There's a mix of outdated links that mention either class components and/or unmaintained libraries, which can be confusing for new developers
  • I went through each link and only kept the ones that had answers which were agnostic about the version of React used (or used React hooks)
    • I had a minor concern about keeping this link because it mentions this.state - I submitted an edit that rewords the sentence more generically to "You're better off using component state and calling it a day."

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c29972:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Nov 13, 2022

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit 0c29972
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/6370c1eba9c8280008bb272f
😎 Deploy Preview https://deploy-preview-4434--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jshoung
Copy link
Contributor Author

jshoung commented Nov 13, 2022

I'm in the process of helping to sweep through the FAQ entries and update things - do let me know if you'd prefer the PRs to be less granular. E.g. one page per PR.

I felt like doing it section-by-section would be easier to review but happy to adjust to whatever works best!

@timdorr
Copy link
Member

timdorr commented Nov 13, 2022

Thanks! This format works well so we don't have small things holding up a larger PR.

@timdorr timdorr merged commit eb79318 into reduxjs:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants