convert combineReducers test to typescript #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
force-pushed
the
cellog-3500-combineReducers.spec.ts
branch
from
3b87f60 to
c2df829
Compare
|
I'm fine with adding the __DO_NOT_USE to the types temporarily. That'll just go in the src files whenever we move the typedefs inline. |
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the
combineReducerstest to typescript. The changes are mostly typing of parameters, but also requires 2 major additions to the typings. The first is export of__DO_NOT_USE__ActionTypesand the second is a change to the definition ofreplaceReducerswhich also requires a small change tocreateStoreThe change to
createStoreis duplicated in PR #3507, which is against master, whereas this PR is againstts-conversion