Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier and format all files #4202

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

aryaemami59
Copy link
Contributor

Overview

Due to this issue which caused prettier to add trailing commas to tsconfig.json files which ultimately resulted in codeSandbox examples failing to compile. We had to add overrides field in .prettier.json in #4190 to resolve the issue. The newest release of Prettier fixes the problem by interpreting tsconfig.json files as json and not jsonc.

This PR:

  • Bumps Prettier to 3.2.5.
  • Removes the overrides field in .prettier.json file as it is no longer needed.
  • Runs Prettier on all files inside the monorepo.

Copy link

codesandbox bot commented Feb 14, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a181a5c:

Sandbox Source
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@EskiMojo14 EskiMojo14 merged commit d712ab3 into reduxjs:master Feb 14, 2024
13 of 14 checks passed
@EskiMojo14
Copy link
Collaborator

thanks!

@aryaemami59 aryaemami59 deleted the bump-prettier branch February 14, 2024 16:34
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit a181a5c
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/65ccea179068b80008ab3bdd
😎 Deploy Preview https://deploy-preview-4202--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants