Only set originalArgs if they're not undefined #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msutkowski
commented
Nov 9, 2021
| @@ -37,7 +37,6 @@ import { | |||
| copyWithStructuralSharing, | |||
| } from '../utils' | |||
| import type { ApiContext } from '../apiTypes' | |||
| import { defaultMemoize } from 'reselect' | |||
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e5fecba:
|
|
I think this should do just fine. I'll give it another look in the evening just to be double sure. |
phryneas
reviewed
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1709.
I believe we can just skip setting this property in the substate when it's
undefined. I double-checked all of the invalidation behavior and this appears to be a non-issue.For a user that uses
originalArgs, there is no difference in the check they'd have to use for this anyways?https://codesandbox.io/s/rtkq-beta-ssr-repro-7q819 - CSB running this build