Add createProvider Documentation. #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azizhk
commented
Jul 22, 2017
| @@ -384,3 +385,41 @@ function selectorFactory(dispatch) { | |||
| export default connectAdvanced(selectorFactory)(TodoApp) | |||
| ``` | |||
|
|
|||
| <a id="createProvider"></a> | |||
| ### `createProvider([storeKey])` | |||
There was a problem hiding this comment.
I wanted to add subKey as well, but then over here:
https://github.com/reactjs/react-redux/blob/a9bb9d3b074eb04f4d7922e22fce733beb148650/src/components/connectAdvanced.js#L78
It is hardcoded to be
const subscriptionKey = storeKey + 'Subscription'So I don't think I could pass it in connect so it was broken anyways
|
LGTM. Thanks! |
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
* Add createProvider docs * Add storeKey to connect options * italics * Update api.md * Add you probably only need this
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
* Add createProvider docs * Add storeKey to connect options * italics * Update api.md * Add you probably only need this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #738
Open to Grammar, Capitalization & Style changes. Also can squash, rebase etc.