Move ref context binding to fix object freezing middleware #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Except now it's creating a new bound function every render. I don't think we want to do this. |
|
LGTM. Thanks! |
|
Oh crap, I didn't follow that code all the way through. Binding in the constructor is super-common. I have a hard time believing redux-freeze can't handle this. I'm not sure why it's touching a component instance anyways. That was never made clear to me. |
timdorr
added a commit
that referenced
this pull request
Jul 6, 2017
)" This reverts commit 2118893.
timdorr
added a commit
that referenced
this pull request
Jul 6, 2017
)" This reverts commit 2118893.
|
Ok. Here you go: #735 |
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
…eduxjs#733)" This reverts commit 2118893.
This was referenced Sep 22, 2019
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
…eduxjs#733)" This reverts commit 2118893.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #708
Middleware that uses
Object.freezesuch as redux-freeze started throwing an error somewhere between versions 5.0.0...5.0.5:This is because
Connectinstances are being mutated here: https://github.com/reactjs/react-redux/blob/2726c59fa1e5929659067df2088c7c6e0d736f3a/src/components/connectAdvanced.js#L124This PR moves the context binding of the ref function to a lazy assignment and doesn't mutate the original function. IMO the intention of the code is clearer this way as well.