Add Forms benchmark, improve DeepTree, and format #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
markerikson
commented
Mar 2, 2019
markerikson
commented
- Added a new "forms" benchmark that creates multiple forms and auto-inputs text into several inputs at once
- Formatted everything with Prettier
- Updated the DeepTree benchmark so that many (1/3 or 1/5) of the components have to update at the same time, as a larger stress test
dai-shi
reviewed
Mar 3, 2019
| } | ||
| }, | ||
| increment(state, action) { | ||
| const { counterId } = action.payload; |
There was a problem hiding this comment.
As incrementMany is the thing, it's not important, but you are missing:
const value = state[counterId] || 0;
state[counterId] = value + 1;
There was a problem hiding this comment.
Whoops, looks like I broke this while making edits! Good catch, thanks.
Aslemammad
pushed a commit
to Aslemammad/react-state-benchmarks
that referenced
this pull request
May 30, 2021
* Refactor runBenchmarks to extract logic * Add prettier * Start formatting things as we go * Add initial empty forms benchmark * Add user-event * Format ALL the things! * Add formatting command * Rework deeptree to update many components at once * Add v7 alpha 3 build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.