Bypass action and meta creators if payload is an Error object #66
Conversation
|
+1 |
|
Imo it shouldn't bypass the meta creators, unless there is a good reason to do so. If the meta creator is needed to handle the action, the action would maybe become useless without the meta information with this PR. What do you think? |
| @@ -34,6 +34,7 @@ | |||
| "chai": "^3.0.0", | |||
| "eslint": "^0.24.0", | |||
| "eslint-config-airbnb": "0.0.6", | |||
| "escope": "3.3.0", | |||
There was a problem hiding this comment.
Is this being used anywhere?
There was a problem hiding this comment.
Not sure if I'm remembering correctly, but I think I needed to add that to bypass an issue with babel-eslint back when redux-actions was on babel 5. I'll remove it now.
estools/escope#99
|
@timche Just saw this. I agree, there could definitely be meta information associated with an error. |
|
@timche Done, meta creator will still be run regardless of error now. Also my bad, should have rebased instead of merged. |
|
Is this still merge-able? |
|
Sorry for the late reply, I was on vacation. |
|
Merged, thanks for the changes :) |
|
It totally reverted #75 |
See #65.