Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative path of input files in output format #870

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

takahi-i
Copy link
Member

@takahi-i takahi-i commented Jan 3, 2020

Ref #869

I make the output formatter have not only input file name but also the paths. The following is an example of the changes.

Is this work for you @tsuyoshicho ?

$ bin/redpen sample-doc/en/sampledoc-en.md
...
[2020-01-03 23:17:09.819][INFO ] cc.redpen.validator.JavaScriptValidator - JavaScript validators directory: js
sample-doc/en/sampledoc-en.md:3: ValidationError[SentenceLength], The length of the sentence (195) exceeds the maximum of 120. at line: Some software tools work in more than one machine, and such distributed (cluster)systems can handle huge data or tasks, because such software tools make use of large amount of computer resources.
sample-doc/en/sampledoc-en.md:3: ValidationError[SymbolWithSpace], Need whitespace after symbol ")". at line: Some software tools work in more than one machine, and such distributed (cluster)systems can handle huge data or tasks, because such software tools make use of large amount of computer resources.
sample-doc/en/sampledoc-en.md:4: ValidationError[SuccessiveWord], Found word "the" repeated twice in succession. at line:  for example, each instance in distributed search engines stores the the fractions of data.
sample-doc/en/sampledoc-en.md:4: ValidationError[EndOfSentence], Found invalid end of sentence "".". at line:  In this article, we'll call a computer server that works as a member of a cluster an "instance".

[2020-01-03 23:17:09.837][ERROR] cc.redpen.Main - The number of errors "4" is larger than specified (limit is "1").

@takahi-i takahi-i force-pushed the make-formatter-output-path branch from b4642ab to 7aca9a8 Compare January 3, 2020 14:46
@tsuyoshicho
Copy link
Contributor

Good it. 😄

@tsuyoshicho
Copy link
Contributor

@takahi-i
Copy link
Member Author

takahi-i commented Jan 5, 2020

Fascinating! I will merge this PR and release a new version.

@takahi-i takahi-i closed this Jan 5, 2020
@takahi-i takahi-i reopened this Jan 5, 2020
@takahi-i takahi-i merged commit d6f8fc2 into redpen-cc:master Jan 5, 2020
@takahi-i takahi-i deleted the make-formatter-output-path branch January 5, 2020 02:10
@takahi-i takahi-i mentioned this pull request Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants