memory: remove libnuma dependency #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seastar is currently pulling in all of libnuma to just invoke a single syscall. Additionally since libnuma being LGPL licensed, it's simpler to not include it as a dependency. Replace the call in numaif.h with a direct syscall. I'm assuming that once libnuma was depended on because it was a dependency of hwloc, however, hwloc version 2 removed the dependency on libnuma, so Seastar can too: https://github.com/open-mpi/hwloc/blob/263908a2c1f21c0e221a8d1f6472daf3a1fc07b9/NEWS#L291 (cherry picked from commit 8ab0267)
rockwotj
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seastar is currently pulling in all of libnuma to just invoke a single syscall. Additionally since libnuma being LGPL licensed, it's simpler to not include it as a dependency. Replace the call in numaif.h with a direct syscall.
I'm assuming that once libnuma was depended on because it was a dependency of hwloc, however, hwloc version 2 removed the dependency on libnuma, so Seastar can too:
https://github.com/open-mpi/hwloc/blob/263908a2c1f21c0e221a8d1f6472daf3a1fc07b9/NEWS#L291
(cherry picked from commit 8ab0267)