[v22.3.x] rpk: do not modify redpanda.rpc_server_tls field #9365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twmb
approved these changes
Mar 10, 2023
Normal use case for starting with rpk is to _not_ use the standard setup from RedpandaTest class so we need to cleanup the node before starting. (cherry picked from commit 834c615)
rpk now will treat this field like an unmanaged field, which means that we can have either a list, or an element, and rpk will respect that. (cherry picked from commit e7e14ae)
These test cover normal scenarios that users might face when migrating to this new version: 1. Enabling TLS from 0 2. Enabling TLS after a cluster is created 3. No knowing that they have the wrong TLS config (cherry picked from commit d99bad7)
If the rpc_tls_server config is a list rpk will do a TLS config validation and print a warning if the config is invalid. (cherry picked from commit 3dfa1d2)
r-vasquez
force-pushed
the
backport-7644-v22.3.x-373
branch
from
f4817e7 to
a2fb241
Compare
For tests that want to know "did node X log message Y" rather than just "was message Y logged anywhere"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #7719
Fixes #9364,