[v22.3.x] kafka: return lowest offset if requested epoch is lower than local log #9297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFLICTS: - exposes log() in cluster/partition.h for tests - test body conflicted with test missing in branch If reading from tiered storage is disabled, we would previously return an offset -1 if the epoch queried fell below the start of our local log. This doesn't match what happens in Kafka, which returns the next available offset in a higher epoch. This behavior is matched by our lookup when reading from cloud storage. This patch updates the Kafka handler to return the start offset of our local log if the requested term falls below the local log's beginning. (cherry picked from commit 350c8ec)
andrwng
changed the title
This test case didn't always actually wait to become leader. Instead, it waited for the leaders table to be populated.
|
CI failure was #9319 |
bharathv
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9264 and #9304
CONFLICTS:
If reading from tiered storage is disabled, we would previously return an offset -1 if the epoch queried fell below the start of our local log.
This doesn't match what happens in Kafka, which returns the next available offset in a higher epoch. This behavior is matched by our lookup when reading from cloud storage.
This patch updates the Kafka handler to return the start offset of our local log if the requested term falls below the local log's beginning.
(cherry picked from commit 350c8ec)
Backports Required
Release Notes
Bug Fixes