Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.3.x] Backport 8548 (Explicitly deregister log metrics) #8556 #9054

Merged
merged 2 commits into from
Feb 28, 2023
Merged

[v22.3.x] Backport 8548 (Explicitly deregister log metrics) #8556 #9054

merged 2 commits into from
Feb 28, 2023

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Feb 22, 2023

Backport #8548

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

None

Release Notes

Bug Fixes

  • A rare issue is fixed where rapidly deleting a topic and recreating a topic with the same name could trigger an assertion

@mmaslankaprv @jcsp
s/probe: added ability to clear registered metrics
5dbbc64 
Signed-off-by: Michal Maslanka <[email protected]>
(cherry picked from commit 21d29a7)
@mmaslankaprv @jcsp
s/disk_log_impl: deregister metrics explicitly when log is closed
a68bf99 
Even when the log is closed some of the user may still hold the log
instance alive preventing metrics from being deregistred. Added explicit
metrics deregistration when log is closed or removed.

Signed-off-by: Michal Maslanka <[email protected]>
(cherry picked from commit dd35d23)
@jcsp jcsp requested a review from mmaslankaprv February 22, 2023 19:13
@jcsp jcsp mentioned this pull request Feb 22, 2023
Closed
6 tasks
@mmaslankaprv mmaslankaprv merged commit 7491a3e into redpanda-data:v22.3.x Feb 28, 2023
@RafalKorepta RafalKorepta added this to the v22.3.x-next milestone Feb 28, 2023
@vshtokman vshtokman modified the milestones: v22.3.x-next, v22.3.14 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
v22.3.14
Development

Successfully merging this pull request may close these issues.
5 participants
@jcsp @dotnwat @vshtokman @RafalKorepta @mmaslankaprv