rpk: bump golangci lint to 1.49.0 #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twmb
previously approved these changes
Sep 8, 2022
r-vasquez
commented
Sep 8, 2022
| @@ -26,10 +26,11 @@ linters-settings: | |||
| misspell: | |||
| locale: US | |||
| nolintlint: | |||
| allow-leading-space: true # don't require machine-readable nolint directives (i.e. with no leading space) | |||
There was a problem hiding this comment.
twmb
previously approved these changes
Sep 8, 2022
rishabh96b
previously approved these changes
Sep 9, 2022
r-vasquez
force-pushed
the
bump-golangci-lint
branch
from
5bc0e95 to
f1057a8
Compare
|
Got #6318 in the first k8s-operator run so I retried because I wanted to make sure that everything was ok... but now we have a new commit in dev that introduced a lint failure. I just force-pushed the rebase + linter fix. Sorry @twmb @rishabh96b |
|
BLOCKER is #6352 |
rishabh96b
previously approved these changes
Sep 12, 2022
This included some changes in comments formats. We are also including a timeout of 5m for the github CI action.
There was a change for nolint directives: golangci/golangci-lint#3109 (comment) And we are adding confidence of 0.8 in revive to avoid false positives.
r-vasquez
force-pushed
the
bump-golangci-lint
branch
from
f1057a8 to
bf5401e
Compare
twmb
approved these changes
Sep 14, 2022
|
/backport v22.2.x |
|
Failed to run cherry-pick command. I executed the below command: |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Bumping golangci-lint to 1.49.0.
This includes some changes in comments formats. We are also including a timeout of 5m for the github CI action.
Backport Required
UX changes
Release notes