Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: bump chart to v5.9.15 to support full podtemplate overrides #344

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

chrisseto
Copy link
Contributor

Prior to this commit the podTemplate field of the redpanda operator had drifted out of sync with that of the helm chart. This prevented users from leveraging the new pod template overrides recently added.

This commit bumps the internal chart version to v5.9.15 updates the PodTemplate type to be a PodSpecApplyConfiguration.

@chrisseto chrisseto force-pushed the chris/p/pod-template-support branch 2 times, most recently from 10265bf to 706c46f Compare December 5, 2024 22:28
@chrisseto chrisseto changed the base branch from chris/p/fix-circular-import to main December 5, 2024 22:30
@chrisseto chrisseto force-pushed the chris/p/pod-template-support branch from 706c46f to 0daf24a Compare December 5, 2024 22:31
@RafalKorepta
Copy link
Contributor

=== RUN   TestDefluxedMinimumVersion
--
  | redpanda_types_test.go:82:
  | Error Trace:	/work/operator/api/redpanda/v1alpha2/redpanda_types_test.go:82
  | Error:      	"NOTE! Alpha feature\nUseFlux flag set to `false` will prevent helm controller from reconciling helm chart. The operator would be\ntight with `go` based Redpanda helm chart version. The rest of the ChartRef fields would be ignored.\n\nBefore setting UseFlux flag to `false` please alight your ChartVersion to at least `5.9.11`\nversion of the Redpanda chart.\n\nRedpandaStatus might not be accurate if flag is set to `false` and HelmRelease is manually deleted.\n\nTo achieve dynamic switch for Flux controllers (HelmRelease and HelmRepository) the resources\nwould not be removed, but they will be put in suspended mode (if flag is provided and set to `false`).\n\nhttps://fluxcd.io/flux/components/helm/helmreleases/#suspend\nhttps://fluxcd.io/flux/components/source/helmrepositories/#suspend" does not contain "5.9.15"
  | Test:       	TestDefluxedMinimumVersion
  | Messages:   	'useFlux' should reference the version "5.9.15" of the go.mod installed redpanda chart. Do you need to run 'task generate' or update the comment?
  | --- FAIL: TestDefluxedMinimumVersion (0.00s)

Prior to this commit the `podTemplate` field of the redpanda operator had
drifted out of sync with that of the helm chart. This prevented users from
leveraging the new pod template overrides recently added.

This commit bumps the internal chart version to v5.9.15 updates the PodTemplate
type to be a PodSpecApplyConfiguration.
@chrisseto chrisseto force-pushed the chris/p/pod-template-support branch from 0daf24a to d44d949 Compare December 6, 2024 14:59
Copy link
Contributor

@andrewstucki andrewstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The applyconfiguration embedding does blow up the CRD definition fairly massively, but 🤷 -- at this point we need the SSA anyway since the CRD is already quite large.

@chrisseto
Copy link
Contributor Author

Yeah, I'm not sure what to do about that one :/ I was expecting the CRD to shrink a touch because apply configs don't include comments. Didn't realize it was such a big increase...

@chrisseto chrisseto merged commit dbe0481 into main Dec 6, 2024
5 checks passed
@chrisseto chrisseto deleted the chris/p/pod-template-support branch December 6, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants