Add Redpanda CRD flag that switch of Flux reconciliation #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RafalKorepta
force-pushed
the
rk/K8S-307/introduce-defulx-option
branch
2 times, most recently
from
e4593ad to
34cbd77
Compare
RafalKorepta
force-pushed
the
rk/K8S-307/introduce-defulx-option
branch
4 times, most recently
from
e2c671e to
6cfc25c
Compare
RafalKorepta
force-pushed
the
rk/K8S-307/introduce-defulx-option
branch
2 times, most recently
from
8aa7d4c to
38a89e6
Compare
chrisseto
reviewed
Sep 19, 2024
RafalKorepta
force-pushed
the
rk/K8S-307/introduce-defulx-option
branch
3 times, most recently
from
d2e8941 to
180d060
Compare
New `Usefulx` boolean flag can turn off Flux reconciliation of HelmRelease and HelmRepository via `suspend` flag in both resources. Regardless of the Flux controllers execution (inside or outside Redpanda operator) Redpanda deployment can be unchanged which gives users not only ability to interveen if something break, but it can act as switch to new execution model without flux controllers. Before setting UseFlux flag to `false` users need to alight ChartVersion to at least `5.9.3` version of the Redpanda chart. The Redpanda reconciller can leave behind Flux custom resources (HelmRelease, HelmChart and HelmRepository) and take ownership of all resources generated by the helm chart. When suspend flag is enabled on mentioned resources user could potenetially delete HelmRelease (using kubectl), but all resources would be unchanged. Current Redpanda operator implementation would quickly re-create HelmRelease CR, but that would still not affect any K8S primitive resource. The analogy could be `kubectl delete --cascade=orphan ...` where main resource is deleted, but the child resources are left unchanged. Reference: https://fluxcd.io/flux/components/helm/helmreleases/#suspend https://fluxcd.io/flux/components/source/helmrepositories/#suspend
As the shell wrapper script was removed in 7a4b48a the `task` invocation is direct now.
RafalKorepta
force-pushed
the
rk/K8S-307/introduce-defulx-option
branch
from
180d060 to
aab02a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Defluxboolean flag can turn off Flux reconciliation of HelmRelease and HelmRepository viasuspendflag in both resources. Regardless of the Flux controllers execution (inside or outside Redpanda operator) Redpanda deployment can be unchanged which gives users not only ability to interveen if something break, but it can act as switch to new execution model without flux controllers.The Redpanda reconciller can leave behind Flux custom resources (HelmRelease, HelmChart and HelmRepository) and take ownership of all resources generated by the helm chart. When suspend flag is enabled on mentioned resources user could potenetially delete HelmRelease (using kubectl), but all resources would be unchanged. Current Redpanda operator implementation would quickly re-create HelmRelease CR, but that would still not affect any K8S primitive resource. The analogy could be
kubectl delete --cascade=orphan ...where main resource is deleted, but the child resources are left unchanged.