CI: lint file generation #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
force-pushed
the
chris/p/lint-generate
branch
3 times, most recently
from
6ed3eae to
24f4f39
Compare
|
Ah, looks like this is running into issues the parent directory not being owned by the buildkite user. Strange the |
chrisseto
force-pushed
the
chris/p/lint-generate
branch
2 times, most recently
from
3b20db1 to
23ee7d8
Compare
RafalKorepta
approved these changes
Aug 27, 2024
Previously it was possible for devs to forget to run `./task generate` which could result in strange CI failures at best or shipping stale manifests in the worst case. This commit adds `git diff --exit-code` to our CI tasks which will cause CI to fail if the generation task produces any unexpected diffs.
RafalKorepta
force-pushed
the
chris/p/lint-generate
branch
from
23ee7d8 to
119d2ae
Compare
|
I think it was for the client side migration tool originally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible for devs to forget to run
./task generatewhich could result in strange CI failures at best or shipping stale manifests in the worst case.This commit adds
git diff --exit-codeto our CI tasks which will cause CI to fail if the generation task produces any unexpected diffs.