This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
HPA Bug fix with updated api version #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPA Bug fix with updated API version Signed-off-by: AB <[email protected]>
|
@charlie-haley Can you prioritize this Fix please. I think I broke HPA when I updated to v2 |
| @@ -17,13 +17,17 @@ spec: | |||
| - type: Resource | |||
There was a problem hiding this comment.
Instead of trying to define the resources, we should probably just change this to take any YAML object, then we dont have to worry about target types/backwards compability, e.g something like:
{{- with .Values.autoscaling.metrics }}
metrics:
{{- toYaml . | indent 4 }}
{{- end }}There was a problem hiding this comment.
I'll merge your current change however, as this will be a breaking change and we'll probably want to ship a few of them together
charlie-haley
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HPA Bug fix with updated API version