Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change image, bump version and remove empty lines #100

Closed
wants to merge 3 commits into from

Conversation

dotdc
Copy link

@dotdc dotdc commented Aug 1, 2024

Did a few changes to use the latest image and version locally.

Changes:

  • Changed image
  • Updated to the latest version
  • Remove empty lines after labels when .Values.commonLabels is empty (you can compare with helm template .)
  • Fixed an error when tracer is configured with openTelemetry, should be open_telemetry_collector

Guess you'll change many things with the rebranding, let me know if you want me to add, change or remove anything from this PR.

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

@dotdc
Copy link
Author

dotdc commented Sep 3, 2024

@charlie-haley could you have a look at this PR?

PS: not sure if you're maintainer, sorry if it's not the case!

@dotdc
Copy link
Author

dotdc commented Dec 3, 2024

Replaced with redpanda-data/helm-charts#1613

@dotdc dotdc closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants