add extraPorts for extraContainers #176
Conversation
|
|
|
politely bumping ... would this PR be acceptable for you? Thx again for your work on the kminion exporter |
charts/kminion/values.yaml
Outdated
| @@ -50,6 +50,7 @@ service: | |||
| type: ClusterIP | |||
| port: 8080 # This port is also used as exposed container port | |||
| annotations: {} # # Annotations to add to the service | |||
| extraPorts: [] | |||
There was a problem hiding this comment.
Could you provide a commented sample value here?
There was a problem hiding this comment.
done ... thanks for your time
|
Hey @cruwe , Generally I recommend to fork the chart at some point if the customization needs are too specific. We can't fit all usecases with a single chart in favour of maintainability and simplicity. I'll be okay with this change, just asked for additional documentation for this parameter in the values.yaml though. Thanks |
cruwe
force-pushed
the
add-extraPorts-for-extraContainers
branch
from
b71f80c to
4bdbda2
Compare
In parallel to extraContainers, extraPorts may be required to scrape additional metrics generated by said extraContainers.
cruwe
force-pushed
the
add-extraPorts-for-extraContainers
branch
from
4bdbda2 to
ba7d561
Compare
|
Hi @weeco, I understand why you do not want excessive customization :-) ... just hoped as []extraContainers does exist, you wouldn't mind the []extraPorts. Thank you for your time and for developing kminion. Cheers! |
In parallel to extraContainers, extraPorts may be required to scrape additional metrics generated by said extraContainers.
Thanks for your work on the kminion prometheus exporter, it has proven to be extremely useful.