Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add daemonset template #119

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Conversation

mrandreyeff
Copy link
Contributor

This adds an option to deploy in daemonset mode, e.g. set:
daemonset: true
replicaCount: 0

Ideally there is a need to move many variables away from "deployment" (or renaming it to more common key), but this require changes in values config for existing deployments, so currently it is being reused.

@weeco
Copy link
Contributor

weeco commented Oct 11, 2021

Hey @mrandreyeff ,
can you explain for what reasons one would want to use a Daemonset instead of a Deployment for KMinion?

@mrandreyeff
Copy link
Contributor Author

mrandreyeff commented Oct 11, 2021

In our particular case the initial goal was to check k8s node may write/read to/from kafka (per node ACLs).
As a pleasant bonus - e2e metrics for each k8s node against kafka cluster.
But worth to note that I disabled gathering most of other metrics to keep pods small (will push the switches later this week), since quite many are gathered by other means (jmx_exporter, burrow, etc).

Pushed here just in case someone needs something similar.

charts/kminion/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@weeco weeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining the usecase, that's interesting and I have not even remotely thought about that. I just added one more comment about how the values should be structured, so that it is extensible in the future.

Thanks!

@weeco weeco merged commit 1dd4368 into redpanda-data:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants