Skip to content

Commit

Permalink
Change default for commitSla to 5s
Browse files Browse the repository at this point in the history
  • Loading branch information
weeco committed Aug 25, 2021
1 parent c4e5e82 commit a3558e0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion e2e/config_consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ type EndToEndConsumerConfig struct {
GroupIdPrefix string `koanf:"groupIdPrefix"`
DeleteStaleConsumerGroups bool `koanf:"deleteStaleConsumerGroups"`

// RoundtripSLA is the time duration from the moment where we try to produce until the moment where we consumed
// the message. Therefore this should always be higher than the produceTimeout / SLA.
RoundtripSla time.Duration `koanf:"roundtripSla"`
CommitSla time.Duration `koanf:"commitSla"`
}
Expand All @@ -17,7 +19,7 @@ func (c *EndToEndConsumerConfig) SetDefaults() {
c.GroupIdPrefix = "kminion-end-to-end"
c.DeleteStaleConsumerGroups = false
c.RoundtripSla = 20 * time.Second
c.CommitSla = 10 * time.Second // no idea what to use as a good default value
c.CommitSla = 5 * time.Second
}

func (c *EndToEndConsumerConfig) Validate() error {
Expand Down

0 comments on commit a3558e0

Please sign in to comment.