Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect): empty lines and otel example #1613

Merged
merged 2 commits into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
#### Added
#### Changed
#### Fixed
* Fixed empty lines after labels when .Values.commonLabels is empty
* Fixed opentelemetry tracer configuration example, should be open_telemetry_collector
#### Removed

### [5.9.15](https://github.com/redpanda-data/helm-charts/releases/tag/redpanda-5.9.15) - 2024-11-29
Expand Down
2 changes: 1 addition & 1 deletion charts/connect/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type: application
# The chart version and the app version are not the same and will not track
# together. The chart version is a semver representation of changes to this
# chart.
version: 3.0.1
version: 3.0.2
ooesili marked this conversation as resolved.
Show resolved Hide resolved

# The app version is the default version of Redpanda to install.
# ** NOTE for maintainers: please ensure the artifacthub image annotation is updated before merging
Expand Down
4 changes: 2 additions & 2 deletions charts/connect/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ helm.sh/chart: {{ include "redpanda-connect.chart" . }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{ with .Values.commonLabels }}
{{- toYaml . -}}
{{- if .Values.commonLabels }}
{{ tpl (toYaml .Values.commonLabels) . }}
{{- end }}
{{- end }}

Expand Down
2 changes: 1 addition & 1 deletion charts/connect/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ serviceMonitor:
# prometheus: {}

# tracing:
# openTelemetry:
# open_telemetry_collector:
# http: []
# grpc: []
# tags: {}
Expand Down
Loading