Fix job annotation overwrite

[RafalKorepta]

aac3d49

Fixed ability to overwrite annotation and labels in Job metadata

b483c4b

Remove none existent post-upgrade-job values
Reference
https://github.com/redpanda-data/helm-charts/releases/tag/redpanda-5.9.6
#1534

helm-charts/CHANGELOG.md

Lines 85 to 92 in 05d3182

	#### Removed
	* `post_upgrade_job.*`, and the post-upgrade job itself, has been removed. All
	it's functionality has been consolidated into the `post_install_job`, which
	actually runs on both post-install and post-upgrade.
	The consolidated job now runs the redpanda-operator image, which may be
	controlled the same way as the additional controllers:
	`statefulset.controllers.{image,repository}`.

[andrewstucki]

Not sure the entire context of this, but made some comments and suggestions about wording for at least the changelog if the desire is to add annotations/labels v. overriding them.

[andrewstucki]

I'm guessing that we have this change since we don't want others to be able to override the helm-specific annotations?

Is there a perceived use-case where we want users to be able to override these?

[RafalKorepta]

I'm guessing that we have this change since we don't want others to be able to override the helm-specific annotations?

It's other way around. If someone would like to override (not recommended) with this change they will be able to change annotation. Merge from mergo works other way around.

Is there a perceived use-case where we want users to be able to override these?

As in the https://redpandacommunity.slack.com/archives/C01AJDUT88N/p1732833410021669 community member would like to delete Job after they succeed.

[andrewstucki]

For this change if PostInstallJob.Labels is considered an override then shouldn't we allow for overriding FullLabels(dot)?

[RafalKorepta]

This change does exactly that. It allows for overriding. I will add test case to assert that generated label by the FullLabel function will be changed if I provide in the same key different label value.

[andrewstucki]

It seems the current implementation isn't really for overriding, but adding additional labels/annotations that we normally wouldn't set? Basically:

helm-charts/charts/redpanda/values.yaml

Lines 555 to 558 in 05d3182

	# -- Additional labels to apply to the Pods of this Job.
	labels: {}
	# -- Additional annotations to apply to the Pods of this Job.
	annotations: {}

If so, then I think the implementation is fine, but this should be something like:

Suggested change

	* ability to overwrite annotation and labels in Job metadata
	* ability to set additional annotation and labels in Job metadata

[RafalKorepta]

This change tries to change the set additional to overwrite even the default one.

The comment references the podTemplate

helm-charts/charts/redpanda/values.yaml

Lines 554 to 558 in 05d3182

	podTemplate:
	# -- Additional labels to apply to the Pods of this Job.
	labels: {}
	# -- Additional annotations to apply to the Pods of this Job.
	annotations: {}

which applies to Job.Spec.Template. This change is focusing on Job.Metadata.[Labels/Annotation].