Skip to content

Commit

Permalink
fix(connect): empty lines and otel example (#1613)
Browse files Browse the repository at this point in the history
* fix(connect): empty lines and otel example

---------

Signed-off-by: David Calvert <[email protected]>
Co-authored-by: Wesley Merkel <[email protected]>
  • Loading branch information
dotdc and ooesili authored Dec 3, 2024
1 parent 7736c4e commit dedfe51
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,11 @@
#### Removed

## Connect Chart
### [Unreleased](https://github.com/redpanda-data/helm-charts/releases/tag/connect-FILLMEIN) - YYYY-MM-DD
#### Fixed
* Fixed empty lines after labels when .Values.commonLabels is empty
* Fixed opentelemetry tracer configuration example, should be open_telemetry_collector

### [3.0.1](https://github.com/redpanda-data/helm-charts/releases/tag/connect-3.0.1)
#### Added
* Parameter to configure submitting anonymous telemetry data
Expand Down
4 changes: 2 additions & 2 deletions charts/connect/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ helm.sh/chart: {{ include "redpanda-connect.chart" . }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{ with .Values.commonLabels }}
{{- toYaml . -}}
{{- if .Values.commonLabels }}
{{ tpl (toYaml .Values.commonLabels) . }}
{{- end }}
{{- end }}

Expand Down
2 changes: 1 addition & 1 deletion charts/connect/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ serviceMonitor:
# prometheus: {}

# tracing:
# openTelemetry:
# open_telemetry_collector:
# http: []
# grpc: []
# tags: {}
Expand Down

0 comments on commit dedfe51

Please sign in to comment.