Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update monitor-health.adoc #872

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Update monitor-health.adoc #872

merged 3 commits into from
Nov 25, 2024

Conversation

Feediver1
Copy link
Contributor

@Feediver1 Feediver1 commented Nov 20, 2024 •
edited
Loading

Description

Resolves https://redpandadata.atlassian.net/browse/DOC-651
Review deadline: Nov 21

Page previews

Preview

Checks

  • New feature
  • Content gap
  • [ X] Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Feediver1 Feediver1 requested a review from a team as a code owner November 20, 2024 21:05
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6744b8aa6dfff400692a015a
😎 Deploy Preview https://deploy-preview-872--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jason-da-redpanda
Copy link
Contributor

Hi @Feediver1

Could we change it so the example has the label as well please

histogram_quantile(0.99, (sum(rate(redpanda_rpc_request_latency_seconds_bucket{redpanda_server="internal"}[5m])) by (le, provider, region, instance, namespace, pod)))

kbatuigas
kbatuigas approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@kbatuigas kbatuigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jason-da-redpanda
jason-da-redpanda approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jason-da-redpanda jason-da-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good thanks

@asimms41 asimms41 merged commit 8faf82f into main Nov 25, 2024
7 checks passed
@asimms41 asimms41 deleted the Feediver1-patch-5 branch November 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-da-redpanda jason-da-redpanda jason-da-redpanda approved these changes

@kbatuigas kbatuigas kbatuigas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feediver1 @jason-da-redpanda @kbatuigas @asimms41