Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc 2599 - Configure Redpanda with a Customer-Managed Key #808

Merged
merged 29 commits into from
Nov 15, 2024

Conversation

Feediver1
Copy link
Contributor

@Feediver1 Feediver1 commented Oct 11, 2024

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/2599

Resolves: https://redpandadata.atlassian.net/browse/DOC-385

Review deadline: Tuesday, Nov 5

NOTE: I was unable to test on GCP (tested on AWS). This was not tested on a BYOC cluster though...

Page previews

https://deploy-preview-808--redpanda-docs-preview.netlify.app/24.3/manage/tiered-storage/#configure-object-storage
Look at both the AWS and GCP tabs.

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Feediver1 Feediver1 requested a review from a team as a code owner October 11, 2024 21:35
@Feediver1 Feediver1 marked this pull request as draft October 11, 2024 21:35
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 81a5ee9
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6735fd92941e4b00083d55af
😎 Deploy Preview https://deploy-preview-808--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Feediver1 Feediver1 marked this pull request as ready for review October 30, 2024 19:03
@Feediver1 Feediver1 changed the base branch from main to v-WIP/24.3 October 30, 2024 19:16
@Feediver1
Copy link
Contributor Author

Received verbal approvals from both @mattschumpert and @deniscoady today in the release sync mtg.

Comment on lines +14 to +15
ifdef::env-cloud[]
You cannot configure a cloud-provider managed encryption key at the topic level or in Redpanda Cloud Dedicated clusters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tiered Storage page isn't single-sourced into the Cloud docs. Not yet, at least.

Copy link
Contributor

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for Linux, but @JakeSCahill please review for K8s content

Doc review feedback

Co-authored-by: Michele Cyran <[email protected]>
@micheleRP
Copy link
Contributor

@Feediver1 are you going to add a blurb in the What's New for this?

@Feediver1 Feediver1 merged commit 183d021 into v-WIP/24.3 Nov 15, 2024
7 checks passed
@Feediver1 Feediver1 deleted the doc-2599 branch November 15, 2024 21:31
Deflaimun pushed a commit that referenced this pull request Nov 19, 2024
Co-authored-by: JakeSCahill <[email protected]>
Co-authored-by: Michele Cyran <[email protected]>
Co-authored-by: Jake Cahill <[email protected]>
Deflaimun pushed a commit that referenced this pull request Dec 2, 2024
Co-authored-by: JakeSCahill <[email protected]>
Co-authored-by: Michele Cyran <[email protected]>
Co-authored-by: Jake Cahill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants