Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User resource docs #773

Merged
merged 51 commits into from
Oct 23, 2024
Merged

Add User resource docs #773

merged 51 commits into from
Oct 23, 2024

Conversation

JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Sep 18, 2024

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/2655
Review deadline: 21 October

Examples are provided by the acceptance tests in the source code: https://github.com/redpanda-data/redpanda-operator/blob/main/acceptance/features/user-crds.feature

Related: redpanda-data/redpanda-operator#256

Page previews

Preview: https://deploy-preview-773--redpanda-docs-preview.netlify.app/24.3/manage/kubernetes/security/authentication/k-user-controller/

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 9e120c6
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6718def0bc2ded000839d21c
😎 Deploy Preview https://deploy-preview-773--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakeSCahill JakeSCahill changed the base branch from main to v-WIP/24.3 October 15, 2024 13:48
@JakeSCahill JakeSCahill marked this pull request as ready for review October 15, 2024 13:49
@JakeSCahill JakeSCahill requested a review from a team as a code owner October 15, 2024 13:49
@JakeSCahill
Copy link
Contributor Author

@JakeSCahill This looks good. Just a more clarifying question, does this doc cover all the fields that are required for User and ACLs? If not, do we need to link to those CRDs directly?

I've added extra links to the CRD reference.

=== Create a new user without any ACLs

- *Use case*: You want to create and manage user credentials (authentication) without managing ACLs. Use this option If you have a separate process to manage ACLs or if you're working in an environment where access control is handled externally.
- *What happens when deleted*: The user is deleted, but ACLs for that user will remain in the cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this a bit confusing--isn't the whole point of this use case that you are not using ACLs for this user? So if you delete a user, why state ACLs remain in the cluster when the use case is that you are not creating any for that user? Is this in the case that someone else has assigned ACLs to this user?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say What happens when the user is deleted:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s more about what happens when the User resource is deleted in Kubernetes. It might not be obvious that if ACLs aren’t defined in the User resource they remain in the cluster even after the resource is deleted.

Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - left a couple suggestions

@david-yu
Copy link
Contributor

Just a nit could we have a direct link to the User and UserList CRDs? https://deploy-preview-773--redpanda-docs-preview.netlify.app/24.3/reference/k-crd/#k8s-api-github.aaakk.us.kg-redpanda-data-redpanda-operator-operator-api-redpanda-v1alpha2-user

@JakeSCahill JakeSCahill requested review from david-yu and removed request for david-yu October 23, 2024 11:38
@JakeSCahill JakeSCahill merged commit dd77c24 into v-WIP/24.3 Oct 23, 2024
7 checks passed
@JakeSCahill JakeSCahill deleted the fix-2655 branch October 23, 2024 13:58
JakeSCahill added a commit that referenced this pull request Oct 28, 2024
Co-authored-by: Paulo Borges <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
@JakeSCahill JakeSCahill mentioned this pull request Oct 28, 2024
4 tasks
Deflaimun added a commit that referenced this pull request Oct 30, 2024
Co-authored-by: Paulo Borges <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
kbatuigas pushed a commit that referenced this pull request Nov 13, 2024
Co-authored-by: Paulo Borges <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
Deflaimun added a commit that referenced this pull request Nov 19, 2024
Co-authored-by: Paulo Borges <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
Deflaimun added a commit that referenced this pull request Dec 2, 2024
Co-authored-by: Paulo Borges <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants