-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for right alt key (altgr) #379
Conversation
Suggestion: You're doing alot of merging to sync your local repository, try rebasing instead ( |
Yeah, At my current workplace, we aren't allowed to rebase, so I kinda lost the habit. I'll try to remember it in the future. |
@polymetric1 Why don't merge? It gives better history than rebasing. |
@ticki The problem with this is that it creates useless commits that are added to pull requests that do nothing. It's fine for merging branch-x with the master branch, hence the name, but when you're syncing a branch with the master, it's better to 1. just don't, or 2. rebase, than to merge. You shouldn't always merge and you shouldn't always rebase. This is kind of a bad explanation but I hope you understand what i mean |
I cannot merge this because it backrevs the rust submodule. You will need to cd rust
git checkout master
git pull And resubmit |
Merging also causes problems like this ^ |
Couldn't have said it better. |
Of course. |
Add support for right alt key (altgr)
I currently don't have access to english and french keyboards, so the altgr-mappings for these layouts might be flawed. But this can easily be fixed afterwards.