Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

No results without keywords #206

Closed
ThomasRoehl opened this issue Feb 14, 2018 · 6 comments
Closed

No results without keywords #206

ThomasRoehl opened this issue Feb 14, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@ThomasRoehl
Copy link
Contributor

Expected Behaviour

Related Conversations should show results based on the tokens found by the nlp analysis. Not only by the keywords extracted from the Wikipedia-core

Actual Behaviour

No Results showed when no keywords are extracted from the message.

Steps to Reproduce

Run Smarti without a Wikipedia-core and test the normal help-request behavior
No Keywords get extracted:
image
But analysis results exist:

{
  "numFound": 2,
  "start": 0,
  "pageSize": 3,
  "docs": [
    {
      "replySuggestion": "Mit allgemeinen Anfragen verschaffen Sie sich einen Überblick über den Markt, indem Sie Produkte, Preise und Bestellbedingungen unterschiedlicher Lieferanten und Dienstleister kennen lernen. In einem allgemeinen Anfragebrief bitten Sie zum die Zusendung von Katalogen, Prospekten, Preislisten und Produktmustern. Wie kann ich dieses Wissen nutzen?",
      "score": 5.1584587,
      "conversationId": "5a8448b6c18fcd53c8e559a0",
      "messageId": "xPpWiroqfQmb6JXCN",
      "content": "Mit allgemeinen Anfragen verschaffen Sie sich einen Überblick über den Markt, indem Sie Produkte, Preise und Bestellbedingungen unterschiedlicher Lieferanten und Dienstleister kennen lernen. In einem allgemeinen Anfragebrief bitten Sie zum die Zusendung von Katalogen, Prospekten, Preislisten und Produktmustern. Wie kann ich dieses Wissen nutzen?",
      "userName": null,
      "messageIdx": 0,
      "votes": 0,
      "timestamp": 1518618806800,
      "answers": [],
      "creator": "queryBuilder:conversationmlt:conversationmlt"
    },
...

When adding keywords, the results are visible:
image

Environment

  • Smarti-Version: Commit-66acf7ad012162c43c4858c2a03689fd8fda3b46
  • Rocket.Chat-Version: Commit-8dbd9cd94d7204d2f87c987d7fa99842faf992d4
@ThomasRoehl ThomasRoehl added this to the v0.7.0 milestone Feb 14, 2018
@westei
Copy link
Member

westei commented Feb 14, 2018

@Peym4n I recently included Tokens for the conversation Search template. Looks like as this needs also to be done for the Widget. Can you please have a look to it.

@westei westei added the ready label Feb 14, 2018
@mrsimpson
Copy link
Collaborator

@westei Are you sure it’s „only“ the UI? It’s not only that the tokens are not visualized, also the query was not executed

@ja-fra
Copy link
Member

ja-fra commented Feb 15, 2018

IMHO this is working as intended. Without tokens, we're not able to query the sources.

The "analysis-result" @ThomasRoehl is referring to is from the conversationmlt-provider - which is working even without tokens, but hidden from the widget (as requested in #189)

@mrsimpson
Copy link
Collaborator

mrsimpson commented Feb 15, 2018

@ja-fra in this case, tokens are extracted, but no keywords. @ThomasRoehl can you add the json of the get to /analysis?

@ja-fra
Copy link
Member

ja-fra commented Feb 15, 2018

Now you got me - Yes, there's a filter in the widget to only show tokens of type !== 'Attribute'.

@mrsimpson
Copy link
Collaborator

mrsimpson commented Feb 22, 2018

The widget has been adapted to show all token types - this works, although there might be some need for boosting (#215)

@ghost ghost removed the in review label Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants