Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[follow-up] perf: optimize struct layout #647

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

proost
Copy link
Contributor

@proost proost commented Oct 13, 2024

follow up: #643

If above PR merged, i merge main branch then cleaned it up.

clusterClient:
스크린샷 2024-10-13 오후 7 27 51

singleClient:
스크린샷 2024-10-13 오후 7 33 31

dedicatedSingleClient:
스크린샷 2024-10-13 오후 7 34 35

dedicatedClusterClient:
스크린샷 2024-10-13 오후 7 36 44

sentinelClient:
스크린샷 2024-10-13 오후 7 50 27

Also, can retryHandler be just a struct instead of a pointer to struct?

@rueian
I don't understand the meaning. you want to change pointer receiver?

@rueian
Copy link
Collaborator

rueian commented Oct 13, 2024

Hi @proost,

The original PR has been merged.

I don't understand the meaning. you want to change pointer receiver?

Never mind, I find retryHandler is an interface. That's fine.

@proost proost force-pushed the refactor-cleanup-retry branch from b3c6568 to 235058d Compare October 14, 2024 14:54
@proost
Copy link
Contributor Author

proost commented Oct 14, 2024

@rueian
I rebase the branch. It is ready to review.

@rueian rueian merged commit 1aee272 into redis:main Oct 14, 2024
27 checks passed
@proost proost deleted the refactor-cleanup-retry branch October 15, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants