Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore MaxFlushDelay for blocking commands #382

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

unknowntpo
Copy link
Contributor

@unknowntpo unknowntpo commented Oct 5, 2023

We check if one or multi has block command, if true, then there's no need to sleep.

We check if one and multi has block command, if true,
then there's no need to sleep.
@unknowntpo
Copy link
Contributor Author

@rueian
Copy link
Collaborator

rueian commented Oct 5, 2023

@rueian This test takes too much time, maybe something is wrong. https://app.circleci.com/pipelines/github/redis/rueidis/1021/workflows/2868a79d-6e02-4b6e-aead-d65fa1c4e01b/jobs/977

It looks like the DragonflyDB crashed during the test. Now the tests are passed after rerun.

@rueian rueian added the bug Something isn't working label Oct 5, 2023
@rueian rueian changed the title Resolve #379 fix: ignore MaxFlushDelay for blocking commands Oct 5, 2023
@unknowntpo
Copy link
Contributor Author

unknowntpo commented Oct 6, 2023

@rueian This test takes too much time, maybe something is wrong. https://app.circleci.com/pipelines/github/redis/rueidis/1021/workflows/2868a79d-6e02-4b6e-aead-d65fa1c4e01b/jobs/977

It looks like the DragonflyDB crashed during the test. Now the tests are passed after rerun.

Thanks for helping!
And BTW, I notice that the test for MaxFlushDelay is weird, it inits a WaitGroup, but didn't use wg.Wait() to wait for it.
What's the purpose of this test?

wg := sync.WaitGroup{}

@rueian
Copy link
Collaborator

rueian commented Oct 6, 2023

@rueian This test takes too much time, maybe something is wrong. https://app.circleci.com/pipelines/github/redis/rueidis/1021/workflows/2868a79d-6e02-4b6e-aead-d65fa1c4e01b/jobs/977

It looks like the DragonflyDB crashed during the test. Now the tests are passed after rerun.

Thanks for helping! And BTW, I notice that the test for MaxFlushDelay is weird, it inits a WaitGroup, but didn't use wg.Wait() to wait for it. What's the purpose of this test?

wg := sync.WaitGroup{}

Yes, the wg is not used and can be removed.

The purpose of that test is just to make sure that the mock.Expect("PING").ReplyString("OK") can be passed.

@rueian rueian merged commit f0f37fc into redis:main Oct 6, 2023
@unknowntpo
Copy link
Contributor Author

rueidis/pipe_test.go

Okay, would you like me to send a PR to remove it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants