Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustered pubsub): check that client.isOpen before calling client.disconnect() when unsubscribing #2687

Merged
merged 4 commits into from
Jan 29, 2024
Merged

fix(clustered pubsub): check that client.isOpen before calling client.disconnect() when unsubscribing #2687

merged 4 commits into from
Jan 29, 2024

Conversation

BrentLayne
Copy link
Contributor

@BrentLayne BrentLayne commented Jan 10, 2024 •
edited
Loading

Description

This PR fixes this issue #2685 whereby concurrent requests to a redis cluster for any of UNSUBSCRIBE, PUNSUBSCRIBE, SSUBSCRIBE can result in ClientClosedError being thrown, due to a race condition between the concurrent requests to disconnect the socket.

It fixes the issue by checking if client.isOpen before calling client.disconnect() in executeShardedUnsubscribeCommand and executeUnsubscribeCommand

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@BrentLayne BrentLayne marked this pull request as ready for review January 10, 2024 15:21
@BrentLayne
Copy link
Contributor Author

I'm running into issues getting npm run build:test-tools to work, so I wasn't able to run the tests locally, but they are pretty simple tests so I expect they should pass in the CI workflow.

@BrentLayne BrentLayne mentioned this pull request Jan 10, 2024
Closed
@BrentLayne BrentLayne changed the title (fix:cluster): check that client.isOpen before calling client.disconnect when unsubscribing fix(cluster): check that client.isOpen before calling client.disconnect when unsubscribing Jan 10, 2024
@BrentLayne BrentLayne changed the title fix(cluster): check that client.isOpen before calling client.disconnect when unsubscribing fix(clustered pubsub): check that client.isOpen before calling client.disconnect when unsubscribing Jan 10, 2024
@BrentLayne BrentLayne changed the title fix(clustered pubsub): check that client.isOpen before calling client.disconnect when unsubscribing fix(clustered pubsub): check that client.isOpen before calling client.disconnect() when unsubscribing Jan 10, 2024
leibale
leibale approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@leibale leibale merged commit 295647c into redis:master Jan 29, 2024
12 checks passed
@leibale leibale linked an issue Jan 29, 2024 that may be closed by this pull request
Concurrent requests to SUNSUBCRIBE causes a race condition bug (ClientClosedError) #2685
Closed
@BrentLayne BrentLayne deleted the patch-sunsubscribe branch March 1, 2024 20:22
@claude-morningstar47 claude-morningstar47 mentioned this pull request Jun 7, 2024
Open
@mcsaur mcsaur mentioned this pull request Jun 21, 2024
Merged
@claude-morningstar47 claude-morningstar47 mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leibale leibale leibale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrent requests to SUNSUBCRIBE causes a race condition bug (ClientClosedError)
2 participants
@BrentLayne @leibale