Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LATENCY LATEST #2514

Merged
merged 7 commits into from
May 29, 2023
Merged

Add support for LATENCY LATEST #2514

merged 7 commits into from
May 29, 2023

Conversation

Karnav123
Copy link
Contributor

@Karnav123 Karnav123 commented May 18, 2023

Fix #1957

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (67d9c3c) 95.67% compared to head (d2f722e) 95.67%.

❗ Current head d2f722e differs from pull request most recent head 18cff90. Consider uploading reports for the commit 18cff90 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2514   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files         455      456    +1     
  Lines        4552     4560    +8     
  Branches      522      524    +2     
=======================================
+ Hits         4355     4363    +8     
  Misses        128      128           
  Partials       69       69           
Impacted Files Coverage Δ
packages/client/lib/commands/XINFO_CONSUMERS.ts 100.00% <ø> (ø)
packages/search/lib/commands/SEARCH.ts 82.60% <ø> (ø)
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/LATENCY_LATEST.ts 100.00% <100.00%> (ø)
packages/search/lib/commands/AGGREGATE.ts 100.00% <100.00%> (ø)
packages/search/lib/commands/CURSOR_READ.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Karnav123
Copy link
Contributor Author

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.16 ⚠️

Comparison is base (67d9c3c) 95.67% compared to head (14741bf) 95.52%.

❗ Current head 14741bf differs from pull request most recent head 26ad2ed. Consider uploading reports for the commit 26ad2ed to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2514      +/-   ##
==========================================
- Coverage   95.67%   95.52%   -0.16%     
==========================================
  Files         455      456       +1     
  Lines        4552     4555       +3     
  Branches      522      522              
==========================================
- Hits         4355     4351       -4     
- Misses        128      133       +5     
- Partials       69       71       +2     
Impacted Files Coverage Δ
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/LATENCY_LATEST.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

My changes are not there in the mentioned files. However, please help me fix the issue. This is my first pull request on this repo.

@Karnav123
Copy link
Contributor Author

@leibale could you please take some time to review this pull request. This is my first PR. Please guide me in case I have missed something.

@leibale
Copy link
Collaborator

leibale commented May 19, 2023

@Karnav123 thanks for contributing! I will next week.. :)

packages/client/lib/commands/LATENCY_LATEST.spec.ts Outdated Show resolved Hide resolved
packages/client/lib/commands/LATENCY_LATEST.ts Outdated Show resolved Hide resolved
@Karnav123
Copy link
Contributor Author

@Karnav123 thanks for contributing! I will next week.. :)

I have implemented your review comments. Please, take a look whenever you have time.

@Karnav123 Karnav123 requested a review from leibale May 22, 2023 05:19
@Karnav123 Karnav123 requested a review from leibale May 25, 2023 08:50
@leibale leibale changed the title Add support for LATENCY LATEST. #1957 Add support for LATENCY LATEST May 29, 2023
@leibale leibale merged commit e696653 into redis:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for redis command: LATENCY LATEST
3 participants