-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cluster extractFirstKey skip commandOptions() passed to args #2439
Conversation
@carlhopf thanks for contributing! Can you please add a test? client.withOptions(...).ping(); |
854bbf1
to
6c5de79
Compare
f965c8f
to
1e5471e
Compare
1e5471e
to
9cbe000
Compare
added/updated the unit test: should assert cluster commands with the suggested chaining |
@carlhopf Sorry for the long delay... wanna review my changes? 🙏 |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2439 +/- ##
==========================================
- Coverage 95.63% 95.62% -0.01%
==========================================
Files 455 455
Lines 4579 4548 -31
Branches 528 520 -8
==========================================
- Hits 4379 4349 -30
+ Misses 129 128 -1
Partials 71 71
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@leibale thanks for the review! good changes 👍🙏 |
Description
in cluster mode the node/slot is calculated based on
extractFirstKey
. skipcommandOptions
if passed as first argumentf.ex.
Checklist
npm test
pass with this change (including linting)?