Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unhandled errors in socket.reconnectStrategry #2226

Merged
merged 7 commits into from
Aug 22, 2022

Conversation

leibale
Copy link
Collaborator

@leibale leibale commented Aug 8, 2022

#2205 #2032

close #2234
fix #2237

@just4fun
Copy link

Hi @leibale , thanks for the fix. Do you have any plan to release it recently? as our new product is facing this issue with the latest node-redis.

@leibale
Copy link
Collaborator Author

leibale commented Aug 21, 2022

Hi @just4fun, I'm planning to release it this week.
Wanna give it a shot before I release it to npm?

@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 1 alert when merging 52f0fb5 into 1fdee05 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@leibale leibale merged commit 942de1f into redis:master Aug 22, 2022
leibale added a commit to leibale/node-redis that referenced this pull request Aug 22, 2022
* handle errors in reconnect strategy

* add test

* fix retries typo

* fix redis#2237 - flush queues on reconnect strategy error

* Update socket.ts

* Update socket.ts
@leibale leibale deleted the reconnect-strategy-errors branch January 24, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working as expected in rainy days error in reconnecting event listener silently prevents reconnection
3 participants