Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample examples to test redis.io build #3051

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Add sample examples to test redis.io build #3051

merged 6 commits into from
Jan 17, 2025

Conversation

uglide
Copy link
Collaborator

@uglide uglide commented Nov 13, 2024

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun
Copy link
Collaborator

tishun commented Nov 15, 2024

@uglide you need to run mvn formatter:format

@github-actions github-actions bot added type: dependency-upgrade A dependency upgrade type: documentation A documentation update type: task A general task labels Nov 22, 2024
@uglide uglide removed the type: dependency-upgrade A dependency upgrade label Nov 22, 2024
@github-actions github-actions bot added the type: dependency-upgrade A dependency upgrade label Nov 22, 2024
@uglide uglide removed the type: dependency-upgrade A dependency upgrade label Nov 22, 2024
@github-actions github-actions bot added the type: dependency-upgrade A dependency upgrade label Nov 22, 2024
@uglide uglide requested a review from tishun November 22, 2024 15:04
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, before your next iteration

@tishun tishun removed the type: dependency-upgrade A dependency upgrade label Dec 2, 2024
@tishun tishun merged commit 6a05e17 into main Jan 17, 2025
6 checks passed
@tishun tishun deleted the doctests branch January 17, 2025 10:06
@tishun tishun restored the doctests branch January 17, 2025 10:07
@tishun tishun mentioned this pull request Jan 17, 2025
3 tasks
@tishun tishun deleted the doctests branch January 20, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants