implementation of PUBSUB SHARDCHANNELS #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atakavci
changed the title
tishun
approved these changes
Mar 20, 2024
| @@ -1635,6 +1636,16 @@ public Mono<Map<K, Long>> pubsubNumsub(K... channels) { | |||
| return createMono(() -> commandBuilder.pubsubNumsub(channels)); | |||
| } | |||
|
|
|||
| @Override | |||
| public Flux<K> pubsubShardChannels() { | |||
| return createDissolvingFlux(() -> commandBuilder.pubsubShardChannels()); | |||
There was a problem hiding this comment.
note (not important) : could use the short syntax here, similar to line 1620
There was a problem hiding this comment.
replaced with method reference
vladvildanov
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation for #2756
due to its similarity, implemented in the same way with PUBSUB CHANNELS command.
Upon completion of the SUBSCRIBE command, test classes need rework just to uncomment the assertions.