Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish RedisObservation name & javadoc #2404

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

be-hase
Copy link
Contributor

@be-hase be-hase commented May 9, 2023

This is trivial fix.
The observation name needs to be discussed.


Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@@ -33,7 +33,7 @@ enum RedisObservation implements ObservationDocumentation {

@Override
public String getName() {
return "spring.data.redis";
return "lettuce";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or lettuce.command ?

@mp911de mp911de added the type: bug A general bug label Jun 26, 2023
@mp911de mp911de added this to the 6.2.5.RELEASE milestone Jun 26, 2023
@mp911de mp911de merged commit 5fe44d5 into redis:main Jul 6, 2023
@mp911de mp911de modified the milestones: 6.2.5.RELEASE, 6.3 Jul 6, 2023
@be-hase be-hase deleted the polish-observation-name branch September 8, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants