Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SlotHash utility methods public #2199

Closed
ze opened this issue Sep 20, 2022 · 1 comment
Closed

Make SlotHash utility methods public #2199

ze opened this issue Sep 20, 2022 · 1 comment
Labels
type: feature A new feature
Milestone

Comments

@ze
Copy link

ze commented Sep 20, 2022

Feature Request

Is your feature request related to a problem? Please describe

I have a use case where I want to use the exact logic in SlotHash.java#partition, but it is package private. This method is useful for doing as it says, partitioning keys by a slot for whatever workload.

Describe the solution you'd like

Make the method public. It may be worthwhile to make getSlots public as well. I haven't used it, but it could be useful.

Describe alternatives you've considered

I copied over the functions to their own utility class and linked to the source, so that is an alternative. It's extra code we need to own though. I don't think any meaningful alternatives exist.

Teachability, Documentation, Adoption, Migration Strategy

Not much really needs to be done. The javadocs are already there.

@mp911de mp911de added the type: feature A new feature label Sep 26, 2022
@mp911de mp911de added this to the 6.2.1.RELEASE milestone Sep 26, 2022
mp911de added a commit that referenced this issue Sep 26, 2022
mp911de added a commit that referenced this issue Sep 26, 2022
@mp911de
Copy link
Collaborator

mp911de commented Sep 26, 2022

That's in place now.

@mp911de mp911de closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants