Ensure single listener notification on exceptional completion #2457

redis · Jul 20, 2023 · a98c8e4 · a98c8e4
1 parent e9c2495
commit a98c8e4
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/src/main/java/io/lettuce/core/CommandListenerWriter.java b/src/main/java/io/lettuce/core/CommandListenerWriter.java
@@ -156,9 +156,7 @@ public RedisCommandListenerCommand(RedisCommand<K, V, T> command, Clock clock, M
         }
 
         @Override
-        public void complete() {
-            super.complete();
-
+        protected void doOnComplete() {
             if (getOutput().hasError()) {
 
                 CommandFailedEvent failedEvent = new CommandFailedEvent((RedisCommand<Object, Object, Object>) command, context,
@@ -173,20 +171,15 @@ public void complete() {
         }
 
         @Override
-        public void cancel() {
-            super.cancel();
-        }
-
-        @Override
-        public boolean completeExceptionally(Throwable throwable) {
-
-            boolean state = super.completeExceptionally(throwable);
-
+        protected void doOnError(Throwable throwable) {
             CommandFailedEvent failedEvent = new CommandFailedEvent((RedisCommand<Object, Object, Object>) command, context,
                     throwable);
             listener.commandFailed(failedEvent);
+        }
 
-            return state;
+        @Override
+        public void cancel() {
+            super.cancel();
         }
 
     }