Support GEOSHAPE field type in RediSearch #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoShape query is limited to PARAM argument only. So I couldn't implement helper functions in query builders. Because of that the dependency library is not required.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3561 +/- ##
============================================
- Coverage 71.48% 71.45% -0.04%
- Complexity 4841 4842 +1
============================================
Files 287 288 +1
Lines 15432 15446 +14
Branches 1093 1093
============================================
+ Hits 11032 11037 +5
- Misses 3924 3931 +7
- Partials 476 478 +2
☔ View full report in Codecov by Sentry. |
chayim
reviewed
Oct 9, 2023
chayim
reviewed
Oct 9, 2023
src/test/java/redis/clients/jedis/examples/GeoShapeFieldsUsageInRediSearch.java
Show resolved
Hide resolved
chayim
reviewed
Oct 9, 2023
src/test/java/redis/clients/jedis/examples/GeoShapeFieldsUsageInRediSearch.java
Outdated
Show resolved
Hide resolved
|
@uglide IMHO docs... Who can help? |
skip-checks: true
Conflicts: pom.xml
sazzad16
added a commit
that referenced
this pull request
Oct 18, 2023
* Support GEOSHAPE field type in RediSearch * dependency: GeoShape query is limited to PARAM argument only. So I couldn't implement helper functions in query builders. Because of that the dependency library is not required. * example * more comments * format * Address code review
sazzad16
added a commit
that referenced
this pull request
Oct 18, 2023
* Support GEOSHAPE field type in RediSearch * dependency: GeoShape query is limited to PARAM argument only. So I couldn't implement helper functions in query builders. Because of that the dependency library is not required. * example * more comments * format * Address code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.