-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Redis version independent error message for NOPERM and system independent locale for Double #3318
Use Redis version independent error message for NOPERM and system independent locale for Double #3318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Locale.ENGLISH
work? If so, please use that.
Otherwise, if Locale.US
is required, mention it as code comment.
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #3318 +/- ##
============================================
- Coverage 67.03% 66.93% -0.10%
+ Complexity 4656 4652 -4
============================================
Files 263 263
Lines 15061 15061
Branches 949 949
============================================
- Hits 10096 10081 -15
- Misses 4560 4572 +12
- Partials 405 408 +3 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Thanks @sazzad16 for your suggestion. |
…ependent locale for Double (redis#3318) * Forcing the locale that has a 'dot' as number format to string format method * Adding a new version of 'noperm' error message related the 'keys'. * Changed locale to 'english' and added comments for that * Undo import format in DocumentTest.java --------- Co-authored-by: M Sazzadul Hoque <[email protected]>
Result
PR related to issue #3315.