Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Redis version independent error message for NOPERM and system independent locale for Double #3318

Merged

Conversation

clebersonp
Copy link
Contributor

  1. Done some adjustments related at the error message 'noperm' for keys adding the new one to the assertion test;
  2. Forced the string's 'format' method with a default locale to ensure the decimal number formated will have the same separator decimal as the assertion's message.

Result

Screenshot from 2023-03-13 21-41-02

PR related to issue #3315.

Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Locale.ENGLISH work? If so, please use that.

Otherwise, if Locale.US is required, mention it as code comment.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (519faa3) 67.03% compared to head (830ac49) 66.93%.

❗ Current head 830ac49 differs from pull request most recent head f6c6e02. Consider uploading reports for the commit f6c6e02 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3318      +/-   ##
============================================
- Coverage     67.03%   66.93%   -0.10%     
+ Complexity     4656     4652       -4     
============================================
  Files           263      263              
  Lines         15061    15061              
  Branches        949      949              
============================================
- Hits          10096    10081      -15     
- Misses         4560     4572      +12     
- Partials        405      408       +3     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@clebersonp
Copy link
Contributor Author

Thanks @sazzad16 for your suggestion. Locale.ENGLISH works fine. I've already done the adjustments

@clebersonp clebersonp requested a review from sazzad16 March 14, 2023 11:26
@sazzad16 sazzad16 changed the title Message and format locale junit adjustments Use Redis version independent NOPERM error message and system independent locale for Double Mar 14, 2023
@sazzad16 sazzad16 changed the title Use Redis version independent NOPERM error message and system independent locale for Double Use Redis version independent error message for NOPERM and system independent locale for Double Mar 14, 2023
@sazzad16 sazzad16 merged commit 70179cc into redis:master Mar 14, 2023
@sazzad16 sazzad16 linked an issue Mar 27, 2023 that may be closed by this pull request
banker pushed a commit to banker/jedis that referenced this pull request Mar 28, 2023
…ependent locale for Double (redis#3318)

* Forcing the locale that has a 'dot' as number format to string format method

* Adding a new version of 'noperm' error message related the 'keys'.

* Changed locale to 'english' and added comments for that

* Undo import format in DocumentTest.java

---------

Co-authored-by: M Sazzadul Hoque <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build tests failed from master branch
3 participants