Address empty cluster slots list when discovering slots #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
suggested changes
Nov 13, 2022
Fixed, also |
sazzad16
changed the title
|
@jgaoIXL Jedis assumes that the But I agree to merge this PR, as a defensive protection. |
src/main/java/redis/clients/jedis/providers/ClusterConnectionProvider.java
Outdated
Show resolved
Hide resolved
|
@yangbodong22011 I've mistakenly deleted one of your comment/suggestion. Sorry about that. |
sazzad16
suggested changes
Nov 16, 2022
src/main/java/redis/clients/jedis/providers/ClusterConnectionProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/providers/ClusterConnectionProvider.java
Outdated
Show resolved
Hide resolved
…rovider.java Co-authored-by: bodong.ybd <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>
…rovider.java Co-authored-by: M Sazzadul Hoque <[email protected]>
sazzad16
approved these changes
Nov 17, 2022
yangbodong22011
approved these changes
Nov 17, 2022
|
Thank you. When are we supposed to see a stable release with this fix? @yangbodong22011 |
|
@jgaoIXL We don't have an exact date yet but this change is available in 4.4.0 snapshot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug that I encountered where
renewClusterSlotswas called when one node was removed from the cluster. The removed node happened to get selected to do thediscoverClusterSlots. Because the removed node return no cluster slots, we have an empty slots cache, and there is no recovery possible from there since the nodes and slots map are all empty.I think it makes sense to return if slotsInfo is size 0 because under no normal circumstances, the cluster should have 0 cluster info provided, it can only mean one thing, which is you are pointing to a node that is not in the cluster.