-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providing JedisPool to be created with abandon config #2054
Conversation
2fa4531
to
4c1f5ad
Compare
@gkorland : Can you approve this PR. This PR has helped us fix an issue by cleaning the connections which are being left active due to various reasons at app level for life time |
Hi @argvk Can you approve this PR. I do not see any use case to write a junit as I am just providing an additonal constructor. This change helps us to fix lot of consumers whose connections are getting stale over time and systems going bad. |
hey @venukbh, I am not a maintainer, and haven't worked on this repo for a long time. You should reach out to the maintainers. |
7a0ac24
to
b47e7f3
Compare
@gkorland Can you take a look and approve. Even Redis enterprise team found it useful. Let me know of any thing to clarify |
b47e7f3
to
e11dc77
Compare
@sazzad16 @karltinawi @ullenius @Talon876 : Can you please take a look at this and merge... This is much needed when the connections are not being released by the system |
Hi all, |
@sazzad16 I do understand about the test cases importance. But I am just providing constructors, and I do not see any existing test cases for constructors as well. |
Author: Venu <[email protected]> Committer: Venu <[email protected]>
e11dc77
to
266a2bc
Compare
@sazzad16 Can you please merge this pr? The change introduced helps a lot of clients using redis to get rid of the connection pool issues. |
hi @venukbh - sorry for the lateness in replying, I am not a maintainer either. Hope you get this merged soon..! |
@venukbh I think that instead of overloading another Constructor (and perhaps many more) we should just expose |
There are a lot of discussions and forums indicating connection issues, maxing out over period of time, connections leakage and not returning to pool.
This abandon config will give the client an option to abandon connections which are not returned back in a specified time - making the connection pool steady and available for app all the time